8000 BUG: Attempt to fix sparc segfault (gh-2668) by mwiebe · Pull Request #2794 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: Attempt to fix sparc segfault (gh-2668) #2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2012
Merged

BUG: Attempt to fix sparc segfault (gh-2668) #2794

merged 2 commits into from
Dec 14, 2012

Conversation

mwiebe
Copy link
Member
@mwiebe mwiebe commented Dec 6, 2012

This is an attempt to fix issue #2668. I don't have a SPARC machine to test it on, can someone check whether the segfault still occurs with this patch?

@rgommers
Copy link
Member
rgommers commented Dec 8, 2012

@matthew-brett could you test this?

@mwiebe
TST: Add a test for bug numpygh-2668
c95da7d 
This is the test attached to the bug from Matthew Brett.
I tried to make a simpler test, but it didn't repro
the problem.
@mwiebe
Copy link
Member Author
mwiebe commented Dec 11, 2012

I've switched the test to the one attached to the bug, as my attempt to make a simpler one didn't work and I don't have access to a sparc machine to experiment with.

@matthew-brett
Copy link
Contributor

Thanks a lot - sorry - I would give you access - but it's not my machine. If you want access to almost anything else - just ask :) - but not SPARC.

@certik
Copy link
Contributor
certik commented Dec 14, 2012

I am on it.

@certik
Copy link
Contributor
certik commented Dec 14, 2012

The patch fixes it!!!!

@mwiebe
Copy link
Member Author
mwiebe commented Dec 14, 2012

Sweet, it worked for Matthew too, and I just had wanted to make a test which took a more direct/obvious route to the bug. Should be good to merge as is though.

certik added a commit that referenced this pull request Dec 14, 2012
@certik
Merge pull request #2794 from mwiebe/complex_copy_misalignment
4f7d3ff 
BUG: Attempt to fix sparc segfault (gh-2668)
@certik certik merged commit 4f7d3ff into numpy:master Dec 14, 2012
@certik
Copy link
Contributor
certik commented Dec 14, 2012

I am merging this. I need to keep reducing the open issues. If you send a new PR, just ping me, I can incorporate it.
Thanks so much for fixing this, it would take me forever to figure out exactly what went wrong.

@certik certik mentioned this pull request Dec 14, 2012
Merged
@certik
Copy link
Contributor
certik commented Dec 14, 2012

Backported in #2817.

@certik certik mentioned this pull request Dec 14, 2012
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
NumPy 1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@mwiebe @rgommers @matthew-brett @certik
0