PERF: add a fast path to ufunc type resolution #27859
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesbury
reviewed
Nov 26, 2024
| PyArray_DTypeMeta *op_dtypes[], | ||
| npy_bool legacy_promotion_is_possible) | ||
| { | ||
| PyObject *info = PyArrayIdentityHash_GetItem(ufunc->_dispatch_cache, |
There was a problem hiding this comment.
I don't think this is thread-safe because we may read from the hash table while another thread is concurrently modifying it, including possibly resizing the table.
There was a problem hiding this comment.
😓 That's a good point.
Is there a thread-safe way to do it without an RW lock?
There was a problem hiding this comment.
We could make PyArrayIdentityHash a concurrent hash table. That's generally hard, but there are a few things that make this specific case easier:
- We only care about concurrent read performance
- Entries are never deleted or overwritten
But we'd still have to deal with hash table resizing, which makes it more complex.
I think a RW lock will be simpler as long as it provides good enough read performance.
|
I'm going to try again using an RW-lock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27786.
Our group is thinking about ways to add better benchmarking so we don't regress on issues like this, see Quansight-Labs/free-threaded-compatibility#117. For now if it's alright I'd just like to merge this fix.
With the test script in the issue and this PR applied, I get the following scaling:
generating this made my laptop pretty hot!