DOC: add examples to ctypeslib #27598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Add examples for ctypeslib: as_array, as_ctypes
- Partially closes DOC: Examples in docstrings – tracking issue #21351
add examples to ctyleslib: as_ctypes, as_array
2a297f3 to
c83ee2e
Compare
|
Looks like the doctests for the new docstrings pass: https://app.circleci.com/pipelines/github/numpy/numpy/29231/workflows/5e8f2bc6-49ae-4a9a-a4a5-4a956971b316/jobs/43146/parallel-runs/0/steps/0-111?invite=true#step-111-39789_26 |
ngoldbaum
reviewed
Oct 19, 2024
numpy/ctypeslib.py
Outdated
| >>> exp_int_array = np.array([1, 2, 3], dtype=np.uint8) | ||
| >>> c_int_array = np.ctypeslib.as_ctypes(exp_int_array) | ||
| >>> c_int_array | ||
| <c_ubyte_Array_3 at 0x10755a950> |
There was a problem hiding this comment.
This is fine to merge as-is, but this repr isn't really helpful. Maybe print something else?
There was a problem hiding this comment.
I added a type check and printing the array contents itself.
Add additional method test on ctype conversion
|
Thanks @m-clare! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.