DOC: add examples for np.ma.convolve #27450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
reviewed
Sep 30, 2024
| >>> from numpy.ma import masked_equal, convolve | ||
| >>> a = masked_equal(np.arange(5), 2) | ||
| >>> b = np.array([1, 1]) | ||
| >>> convolve(a, b) |
There was a problem hiding this comment.
Sorry for the late comment. This looks fine, I think most of the code just uses np.ma.<function> without explicit import, so maybe that would be clearer?
One other suggestion I have would be to print out a (just with >>> a), since I am not sure that it is easy for users to grasp without seeing it.
|
Hi @infinity-void6 - are you interested in finishing this up? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of 2024 Pycon India Blr Devsprint, I took this issue: #21351 and added an example for the docstring of the method np.ma.convolve with the help of @seberg