8000 DOC: Add a link to the migration guide for the deprecation warning of the copy keyword by hmaarrfk · Pull Request #27440 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

DOC: Add a link to the migration guide for the deprecation warning of the copy keyword #27440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk changed the title DOC: Add a link to the migration guide for the deprecation warning DOC: Add a link to the migration guide for the deprecation warning of the copy keyword Sep 22, 2024
"'dtype' and 'copy' keyword arguments.") < 0) {
"'dtype' and 'copy' keyword arguments. "
"To learn more, see the migration guide "
"https://numpy.org/devdocs/numpy_2_0_migration_guide.html#adapting-to-changes-in-the-copy-keyword") < 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A 128 character line is hideous :) And there is no guarantee that it will print without breaking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove the "#" if you want?

I didn't really know there was a migration guide until i asked #25941 (comment) and took some of your time...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just break the line with quotes. Python combines all quoted bits into one string.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh you mean hideous in the code, not hideous for the end user.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i made the mod, but i don't think the OSX error is related right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OSX error is fixed in main.

@charris charris merged commit 87c0c63 into numpy:main Sep 23, 2024
66 of 67 checks passed
@charris
Copy link
Member
charris commented Sep 23, 2024

Thanks @hmaarrfk .

@hmaarrfk
Copy link
Contributor Author

thank you for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0