BUG: Bump Highway to latest master #27070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-devulap
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
@neutrinoceros verified that this patch fixes the bug. #27037 (comment)
@Mousius could you add a test in NumPy to add coverage for such sorting array with duplicate values? |
|
@r-devulap lets not talk about how the test was the first thing I wrote and still forgot to include it in the PR 🙀 |
|
Thanks @Mousius . |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jul 29, 2024
* Bump Highway to latest master Fixes numpy#27037 * Add reproducer
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jul 29, 2024
* Bump Highway to latest master Fixes numpy#27037 * Add reproducer
ArvidJB
pushed a commit
to ArvidJB/numpy
that referenced
this pull request
Nov 1, 2024
* Bump Highway to latest master Fixes numpy#27037 * Add reproducer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27037