8000 BUG: fix f2py tests to work with v2 API by charris · Pull Request #26971 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: fix f2py tests to work with v2 API #26971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024
Merged

BUG: fix f2py tests to work with v2 API #26971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
BUG: fix f2py tests to work with v2 API 
This is a clear bug which CI unfortunately doesn't see because it
just skips the f2py test if compilation fails (which it does here).

The error is slightly more precise now, but not precise enough to
avoid that issue.
  • Loading branch information
@paddyroddy @charris
paddyroddy authored and charris committed Jul 17, 2024
commit 6d950e9af15d52c47f8e31141b206808fd665b72
2 changes: 1 addition & 1 deletion numpy/f2py/tests/src/array_from_pyobj/wrapmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ static PyObject *f2py_rout_wrap_attrs(PyObject *capi_self,
PyArray_DESCR(arr)->type,
PyArray_TYPE(arr),
PyArray_ITEMSIZE(arr),
PyArray_DESCR(arr)->alignment,
PyDataType_ALIGNMENT(arr),
PyArray_FLAGS(arr),
PyArray_ITEMSIZE(arr));
}
Expand Down
2 changes: 1 addition & 1 deletion numpy/f2py/tests/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ def build_meson(source_files, module_name=None, **kwargs):
# compiler stack is on the CI
try:
backend.compile()
except:
except subprocess.CalledProcessError:
pytest.skip("Failed to compile module")

# Import the compiled module
Expand Down
Loading
0