TYP,BUG: fix numpy.__dir__ annotations
#26867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy.__dir__ annotationsnumpy.__dir__ annotations
ee5c8bf to
aedb52c
Compare
numpy.__dir__ annotationsnumpy.__dir__ annotations
numpy.__dir__ annotationsnumpy.__dir__ annotations
aedb52c to
a8a42f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy.__dir__annotated as alist[str], which is incorrect:This PR changes its annotation to
() -> Sequence[str].Since the mutability of the return value isn't relevant (and considered to be practice), a
collections.abc.Sequencewas used as return type, as opposed to alist.Although mostly irrelevant in this particular case, an additional benefit of using a
Sequencein place of alistas (return) annotation, is that the type parameter ofSequenceis covariant, whereas that oflistis invariant.