TYP: add missing annotations for numpy.object_.__new__
#26865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy.object_.__new__numpy.object_.__new__
2d6021f to
414efe1
Compare
|
Hi! Thanks so much for your PRs to improve NumPy's typing. Unfortunately our bandwidth to review these PRs isn't very high right now and it may take a while to review. You may want to drop by one of our community or PR triage meetings on Wednesdays to introduce yourself and give a little context to your PRs, see the NumPy community calendar for dates and times. Ping @BvB93, there are a few other typing PRs from the same author too. |
numpy.object_.__new__numpy.object_.__new__
b72d0c7 to
64f79e6
Compare
9736679 to
3378362
Compare
3378362 to
e971242
Compare
|
Thanks @jorenham . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a mypy bug (python/mypy#15182), this cannot be type-tested.
However, I confirmed that with pyright, the (currently commented-out) typetests succeed.
According to the official typing specs, these
__new__annotations are valid, as wellPreviously,
np.object(...)always returned an instance ofnp.object_according to its annotations.Due to the mypy bug, mypy still thinks it does.
But other typecheckers, e.g. pyright, now correctly types that e.g.
object_() -> None.object_('spam') -> 'spam', andobject_([]) -> array([], dtype=object).