TST: Re-enable int8/uint8 einsum tests #26602
Conversation
It seems numpy#24732 fixed itself, see the following CI runs: - github.com/JuliaPoo/numpy/actions/runs/9344912430/job/25716839862 - github.com/JuliaPoo/numpy/actions/runs/9344767573/job/25716459859
There was a problem hiding this comment.
That's good news:) Thanks for the PR @JuliaPoo.
Could you please also clean up the definition of USING_CLANG_CL near the top of the file, since it's no longer used?
Also, let's make doubly sure it's gone everywhere - when making that change, could you add [wheel build] to the first line of the commit message? That triggers a full set of wheel builds; those can have different compile flags, so it's useful to check.
I don't really mind not knowing what fixed it - could be changed to SIMD code, move to C17, type promotion changes, a change in the compilers, or just some random fix somewhere.
|
There is a similar code pattern in scalar math's |
This is a follow up of numpy#26602 and numpy#24162 where previously the test fails on Clang-cl. I've tried a few CI runs on my fork and it seems the test passes now.
|
No need to wait for the PyPy wheel build. LGTM. |
|
Thanks @JuliaPoo |
It seems #24732 fixed itself, see the following CI runs: