BUG: fix incorrect error handling for dtype('a') deprecation #26524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Nathan. |
seberg
reviewed
May 25, 2024
| self.assert_deprecated(f) | ||
| f = lambda: np.array(["hello", "world"]).astype("a10") | ||
| self._check_for_warning(f) | ||
| self.assert_deprecated(f) |
There was a problem hiding this comment.
Thanks for the quick fix! It doesn't matter, just FYI: assert_deprecated checks for both the warning and the error path, all that is needed to make it specific is setting message = ... as a class variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26521