10000 TST: add basic free-threaded CI testing by ngoldbaum · Pull Request #26463 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

TST: add basic free-threaded CI testing #26463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2024
Merged

TST: add basic free-threaded CI testing #26463

merged 1 commit into from
May 21, 2024

Conversation

ngoldbaum
Copy link
Member
@ngoldbaum ngoldbaum commented May 16, 2024 •
edited
Loading

No description provided.

@ngoldbaum ngoldbaum added 05 - Testing component: CI 39 - free-threading PRs and issues related to support for free-threading CPython (a.k.a. no-GIL, PEP 703) labels May 16, 2024
@ngoldbaum ngoldbaum marked this pull request as ready for review May 16, 2024 21:27
@ngoldbaum ngoldbaum mentioned this pull request May 16, 2024
Closed
16 tasks
@rgommers rgommers self-requested a review May 21, 2024 12:27
rgommers
rgommers approved these changes May 21, 2024
View reviewed changes
Copy link
Member
@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ngoldbaum! This LGTM modulo one typo in the job config.

This all seems to work as advertised; the correct Python is pulled in, the Cython wheel build tag contains cp313t (t for free-threaded), and the NumPy under test picks up the correct Python:

 Program python3 found: YES (/home/runner/venv-3.13/bin/python3.13-nogil)

Feel free to merge after fixing the typo.

.github/workflows/linux.yml Outdated
free-threaded:
needs: [smoke_test]
runs-on: ubuntu-latest
if: github.even_name != 'push'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Lea 8000 rn more.

typo: event_name

@ngoldbaum
TST: add basic free-threaded CI testing
1801aa2 
[skip azp] [skip cirrus] [skip circle]
@ngoldbaum ngoldbaum merged commit b36f848 into numpy:main May 21, 2024
59 checks passed
@andfoy andfoy mentioned this pull request May 28, 2024
Merged
@lesteve lesteve mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
05 - Testing 39 - free-threading PRs and issues related to support for free-threading CPython (a.k.a. no-GIL, PEP 703) component: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngoldbaum @rgommers
0