8000 DOC: Bump pydata-sphinx-theme version by charris · Pull Request #26305 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

DOC: Bump pydata-sphinx-theme version #26305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

charris
Copy link
Member
@charris charris commented Apr 18, 2024

Backport of #26125.

Fixes #26058.

Fixes inaccessible contrast for a:visited links in admonitions.

Note: I didn't manage to build everything locally to test this out, does the CI generate a preview build?

hugovk and others added 7 commits April 18, 2024 10:01
Fixes inaccessible contrast for a:visited links in admonitions. Fixes numpy#26058.
Caused by: WARNING: the pydata_sphinx_theme extension is not safe for parallel writing
[skip azp] [skip cirrus]
This helps adjust the flow of the navbar items.

[skip azp][skip cirrus]
@charris charris added 04 - Documentation 08 - Backport Used to tag backport PRs labels Apr 18, 2024
@charris charris added this to the 2.0.0 release milestone Apr 18, 2024
@melissawm
Copy link
Member

@melissawm
Copy link
Member

I see that there are still some issues with the spacing of the navbar (depending on the active section, there is a weird truncation of the section titles)

Can I try and fix that before we backport? Is it ok if I just push a commit to this PR?

@charris charris merged commit 30985f8 into numpy:maintenance/2.0.x Apr 18, 2024
@charris charris deleted the backport-26125 branch April 18, 2024 22:12
@charris
Copy link
Member Author
charris commented Apr 18, 2024

Can I try and fix that before we backport?

Sure, but it is already in. Just push a new PR to main and I will backport it.

@melissawm
Copy link
Member

Thanks, @charris !

@melissawm
Copy link
Member

Here you go: #26311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04 - Documentation 08 - Backport Used to tag backport PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0