BUG: Filter out broken Highway platform #26000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mitigation for a heisenbug, xref #25464 |
rgommers
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
LGTM, thanks @Mousius. This looks right - let's get it in, so there is no time pressure on re-enabling it.
I've marked it for backporting to 2.0.x. This will also require a tweak to the 2.0.0 release notes (EDIT: actually it doesn't, since linux aarch64 is still enabled) - I'll take that along with another change that I am making right now.
|
I wonder what the actual performance change is on a macos |
|
Is it a compiler bug or a platform issue? I thought it related to Clang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.