CI, MAINT: use fetch-tags: true to speed up NumPy checkouts
#25900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
reviewed
Feb 28, 2024
This commit performs the following changes: 1. It uses the fetch-tags: true input for the GitHub Actions checkout step for all of the workflows 2. It de-quotes the condition for disabling jobs on forks, wherever applicable – it removes some JSON schema warnings emitted in Visual Studio Code. 3. In some locations, comments have been added that prompt users to comment out the condition in point 2 to run it on their forks. [skip circle] [skip cirrus] [skip azp]
b519d70 to
9858434
Compare
|
Thanks @agriyakhetarpal . I suspect the lint problem might be the branch name, but have now idea what it should be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request performs the following changes:
fetch-tags: trueinput for the GitHub Actions checkout step for all of the workflows, which is faster and should save us some time (see the Usage section of the documentation foractions/checkout@v4.1.1)for disabling jobs on forks, wherever applicable – it removes some warnings related to the JSON schema for GitHub Actions that were being raised in my text editor; i.e., Visual Studio Code.
3. In some locations, some missing comments have been added that prompt users to comment out the condition in point 2 to run it on their forks. This has not been done for smaller jobs, and mostly for jobs with longer durations.
This was requested in the code review stage in gh-25894