8000 BUG: Fix gh-25867 for used functions and subroutines by HaoZeke · Pull Request #25881 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUG: Fix gh-25867 for used functions and subroutines #25881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2024

Conversation

HaoZeke
Copy link
Member
@HaoZeke HaoZeke commented Feb 25, 2024

There's a small refactor here (first commit, can be removed). The fix here was to wrap modules which have functions and subroutines. This was what was supposed to be implemented in #25361. Also has a new test for the fix.

< 8000 span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;">
@HaoZeke
Copy link
Member Author
HaoZeke commented Feb 25, 2024

@mancellin this should fix capytaine, could you check? (neat project by the way!)

@HaoZeke
Copy link
Member Author
HaoZeke commented Feb 25, 2024

CI failure seems unrelated.

After this operation, 139 MB of additional disk space will be used.
Get:1 file:/etc/apt/apt-mirrors.txt Mirrorlist [142 B]
Get:2 http://azure.archive.ubuntu.com/ubuntu jammy/main amd64 libjsoncpp25 amd64 1.9.5-3 [80.0 kB]
Get:3 http://azure.archive.ubuntu.com/ubuntu jammy/main amd64 librhash0 amd64 1.4.2-1ubuntu1 [125 kB]
Get:4 http://azure.archive.ubuntu.com/ubuntu jammy/main amd64 dh-elpa-helper all 2.0.9ubuntu1 [7610 B]
Ign:5 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main amd64 cmake-data all 3.22.1-1ubuntu1.22.04.1
Ign:6 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main amd64 cmake amd64 3.22.1-1ubuntu1.22.04.1
Get:7 http://azure.archive.ubuntu.com/ubuntu jammy/universe amd64 libopenblas0-pthread amd64 0.3.20+ds-1 [6803 kB]
Ign:5 http://archive.ubuntu.com/ubuntu jammy-updates/main amd64 cmake-data all 3.22.1-1ubuntu1.22.04.1
Ign:6 http://archive.ubuntu.com/ubuntu jammy-updates/main amd64 cmake amd64 3.22.1-1ubuntu1.22.04.1
Get:8 http://azure.archive.ubuntu.com/ubuntu jammy/universe amd64 libopenblas0 amd64 0.3.20+ds-1 [6098 B]
Err:5 http://security.ubuntu.com/ubuntu jammy-updates/main amd64 cmake-data all 3.22.1-1ubuntu1.22.04.1
  404  Not Found [IP: 20.106.104.242 80]
Get:9 http://azure.archive.ubuntu.com/ubuntu jammy/universe amd64 libopenblas-pthread-dev amd64 0.3.20+ds-1 [4634 kB]
Err:6 http://security.ubuntu.com/ubuntu jammy-updates/main amd64 cmake amd64 3.22.1-1ubuntu1.22.04.1
  404  Not Found [IP: 20.106.104.242 80]
Get:10 http://azure.archive.ubuntu.com/ubuntu jammy/universe amd64 libopenblas-dev amd64 0.3.20+ds-1 [18.6 kB]
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/c/cmake/cmake-data_3.22.1-1ubuntu1.22.04.1_all.deb  404  Not Found [IP: 20.106.104.242 80]
Fetched 11.7 MB in 1s (12.5 MB/s)
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/c/cmake/cmake_3.22.1-1ubuntu1.22.04.1_amd64.deb  404  Not Found [IP: 20.106.104.242 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Error: Process completed with exit code 100.

@charris
Copy link
Member
charris commented Feb 25, 2024

The BLAS test failures may be due to not basing on current main.

@charris charris merged commit 90f8eeb into numpy:main Feb 25, 2024
@charris
Copy link
Member
charris commented Feb 25, 2024

Thanks @HaoZeke .

@HaoZeke HaoZeke deleted the gh25867_fix_use_module_func_sub branch February 25, 2024 22:00
@mancellin
Copy link

@mancellin this should fix capytaine, could you check? (neat project by the way!)

Thank you @HaoZeke. I will test this as soon as possible.

@mancellin
Copy link

Everything seems to work fine on the latest nightly builds 🎉

@HaoZeke HaoZeke restored the gh25867_fix_use_module_func_sub branch June 15, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0