8000 CI: cygwin 3.9.18 stalls in pip install with progress bars by mattip · Pull Request #25714 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

CI: cygwin 3.9.18 stalls in pip install with progress bars #25714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

CI: cygwin 3.9.18 stalls in pip install with progress bars #25714

wants to merge 2 commits into from

Conversation

mattip
Copy link
Member
@mattip mattip commented Jan 29, 2024

[skip azp][skip circle][skip cirrus]

Fixes #25708, apparently it is enough to disable progress bars. Maybe we should do this globally with a PIP_CONFIG_FILE, I doubt anyone enjoys seeing the progress reports in CI.

seberg
seberg approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member
@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice look like that really fixed it. Disabling the progress bar for CI in general seems like a nice idea (in which ever capacity), but this is great to just get fixed also.

@mattip
Copy link
Member Author
mattip commented Jan 29, 2024

No, now it seems stuck on 63% of tests

@seberg
Copy link
Member
seberg commented Jan 29, 2024

FFT crashing in some thread-safety tests (the test that should run next) does seem like it may be an actual new issue? Ping @mhvk, although not sure if you are likely to have much insight.

If that is the case, it might make sense to just put this in anyway...

@rgommers
Copy link
Member

Maybe we should do this globally with a PIP_CONFIG_FILE, I doubt anyone enjoys seeing the progress reports in CI.

I'm not sure why, since there has never any problem before and in principle progress bar output in pip is there to avoid timeouts (zero output for a long time may cause CI to kill a job). Don't touch it unless there's a problem beyond Cygwin I'd say.

@rgommers rgommers changed the title BUG: cygwin 3.9.18 stalls in pip install with progress bars CI: cygwin 3.9.18 stalls in pip install with progress bars Jan 29, 2024
@rgommers
Copy link
Member

Agreed that this seems fine to merge as is. What could be useful to check if the fft hang is new or a coincidence is to rebase this progress bar fix to before all the fft changes on a separate branch and trigger the Cygwin job on that branch.

@EliahKagan EliahKagan mentioned this pull request Jan 29, 2024
Closed
@mattip mattip mentioned this pull request Jan 29, 2024
Merged
@mattip
Copy link
Member Author
mattip commented Jan 29, 2024

Closing in favor of #25716

@mattip mattip closed this Jan 29, 2024
@charris charris mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberg seberg seberg approved these changes

Assignees
No one assigned
Labels
00 - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: cygwin job is timing out at over 6 hours
3 participants
@mattip @seberg @rgommers
0