BUG: Use large file fallocate on 32 bit linux platforms #25630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a local prototype for fallocate instead of the fcntl.h header meant that the redirect triggered by -D_FILE_OFFSET_BITS=64 was not triggered. The prototypes in feature_detection_stdio.h should only be used by functions in setup_common.py. If they are used by the feature discovery code they might trigger false positives.
Member
|
Closing this, we’ll review the PR to main and if that gets merged do a backport afterwards per our normal process. |
Member
|
This is the backport of #25631 which was merged after triage discussion. |
Member
|
Thanks @snogge . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a local prototype for fallocate instead of the fcntl.h header meant that the redirect triggered by -D_FILE_OFFSET_BITS=64 was not triggered.
The prototypes in feature_detection_stdio.h should only be used by functions in setup_common.py. If they are used by the feature discovery code they might trigger false positives.
A similar but not identical PR #25631 has been pushed for master.