BUG: Allow None as api_version in __array_namespace__ method
#25595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None as api_version in __array_namespace__ functionNone as api_version in __array_namespace__ method
None as api_version in __array_namespace__ methodNone as api_version in __array_namespace__ method
None as api_version in __array_namespace__ methodNone as api_version in __array_namespace__ method
rgommers
approved these changes
Jan 17, 2024
numpy/_core/src/multiarray/methods.c
Outdated
| { | ||
| PyErr_Format(PyExc_ValueError, | ||
| "Only None and strings are allowed as the Array API version.", | ||
| array_api_version); |
There was a problem hiding this comment.
minor: this looks like a leftover. you can either remove it, or add something like ", but received ...".
There was a problem hiding this comment.
Right, I added array_api_version to the error message.
7518655 to
5275d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rgommers,
This bugfix PR updates
ndarray.__array_namespace__implementation so:is now allowed, as stated in the standard.