BUG: handle scalar input in np.char.replace #25484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged #25171 last night. However, it was never updated to handle scalars properly following #25335, so the test added in that PR started failing as soon as #25171 was merged.
This updates the
replace
implementation to properly handle scalars following the other chararray functions.ping @lysnikolaou if you happen to see this and want to do it another way, please let me know, I just did this quickly to fix CI.