10000 BUG: handle scalar input in np.char.replace by ngoldbaum · Pull Request #25484 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUG: handle scalar input in np.char.replace #25484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

ngoldbaum
Copy link
Member

I merged #25171 last night. However, it was never updated to handle scalars properly following #25335, so the test added in that PR started failing as soon as #25171 was merged.

This updates the replace implementation to properly handle scalars following the other chararray functions.

ping @lysnikolaou if you happen to see this and want to do it another way, please let me know, I just did this quickly to fix CI.

Copy link
Member
@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, scalar return logic is of course in the air (it's not the same as ufuncs), but unchanged here and presumably before.

Copy link
Member
@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0