-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
ENH: Make numpy.array_api more portable #25370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3b20ad9
Replace device="cpu" with a special object in numpy.array_api
asmeurer 13ab654
Use separate wrapped dtype objects in numpy.array_api
asmeurer 28a15d5
Disallow 0-dimensional arrays in numpy.array_api.nonzero
asmeurer 84a4605
Update some items in the array_api compatibility document
asmeurer 64c7478
Add a release notes entry
asmeurer 700ded8
Fix some type hint aliases for numpy.array_api
asmeurer 4f2b67a
Fix bug in numpy.array_api.asarray with copy=True
asmeurer 595342c
Make numpy.array_api dtypes issue a warning when compared against num…
asmeurer 8e2af02
Fix some linter issues
asmeurer 0915030
Add stacklevel to a warning
asmeurer 61f97f0
Merge branch 'main' into array_api-portability
asmeurer 7f354e5
Fix the array_api fft creation functions to use the custom CPU_DEVICE…
asmeurer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
Make ``numpy.array_api`` more portable | ||
-------------------------------------- | ||
|
||
``numpy.array_api`` no longer uses ``"cpu"`` as its "device", but rather a | ||
separate ``CPU_DEVICE`` object (which is not accessible in the namespace). | ||
This is because "cpu" is not part of the array API standard. | ||
|
||
``numpy.array_api`` now uses separate wrapped objects for dtypes. Previously | ||
it reused the ``numpy`` dtype objects. This makes it clear which behaviors on | ||
dtypes are part of the array API standard (effectively, the standard only | ||
requires ``==`` on dtype objects). | ||
|
||
``numpy.array_api.nonzero`` now errors on zero-dimensional arrays, as required | ||
by the array API standard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this release note; it can be cleaned up if and when we split off the whole
numpy.array_api
module into a standalone package.