10000 BUG: Fix moving compiled executable to root with f2py -c on Windows by jmrohwer · Pull Request #25160 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUG: Fix moving compiled executable to root with f2py -c on Windows #25160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

jmrohwer
Copy link
Contributor

This is a follow up to #25000 (bug report) and #25073 (PR) which fixed f2py compilation under Windows using f2py -c by declaring quadmath as dependency and referring to compatible Windows toolchains in the documentation.

The f2py compile still does not work as expected under Windows as the compiled binary is not moved to the root directory after compile. This PR fixes that by searching for *.pyd files in addition to *.so files in the build directory.

Copy link
Member
@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks.

@HaoZeke HaoZeke merged commit a091a25 into numpy:main Nov 17, 2023
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0