ENH: Added fill option to np.atleast_2d and np.atleast_3d
#25126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fill option to np.atleast_2d and np.atleast_3d
fill option to np.atleast_2d and np.atleast_3dfill option to np.atleast_2d and np.atleast_3d
|
I don't quite know how to fix the failing tests (if it is a dispatcher signature problem, I tried to guess from other functions I could look at, but I don't exactly understand how they work). Some help + review would be appreciated :) |
|
Hi @eliegoudout - there's a couple of things. First, you created this PR on top of you main branch, and that is not recommended. Ideally, you could move your changes to a new branch and re-submit this PR. Please check out our contributing guide for more instructions 😄 |
|
Thanks, @melissawm, I did just that: #25170. Also, thanks for the pointer to the doc, but I dont think you can expect everyone to read it in full. It is still a great ressource when one knows what to look for! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional keyword argument
filltonp.atleast_2dandnp.atleast_3d, to specify where the missing dimension(s) should be added.np.atleast_1dfor obvious reasons, but if signature consistency is an issue, it can be done,This can be useful when working with Fortan convention for example, or for locally-specifi reasons.