8000 BLD: Fix features.h detection and blocklist complex trig funcs on musl by mbargull · Pull Request #25092 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BLD: Fix features.h detection and blocklist complex trig funcs on musl #25092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2023
Merged

BLD: Fix features.h detection and blocklist complex trig funcs on musl #25092

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dbdb8d5
BLD: Fix features.h detection for Meson builds
mbargull Nov 8, 2023
1d9a6f4
TST: add a test
mattip Nov 9, 2023
cab680c
BLD: blocklist complex trig functions on musl
mattip Nov 9, 2023
c77ab47
unskip musl complex trig tests
mattip Nov 9, 2023
9ea36bf
frexp is still not right on musl
mattip Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
frexp is still not right on musl
  • Loading branch information
@mattip
mattip committed Nov 9, 2023
commit 9ea36bf498fd1540ac79f2a2637fe01a9d79998b
4 changes: 3 additions & 1 deletion numpy/_core/tests/test_umath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
assert_, assert_equal, assert_raises, assert_raises_regex,
assert_array_equal, assert_almost_equal, assert_array_almost_equal,
assert_array_max_ulp, assert_allclose, assert_no_warnings, suppress_warnings,
_gen_alignment_data, assert_array_almost_equal_nulp, IS_WASM, IS_PYPY
_gen_alignment_data, assert_array_almost_equal_nulp, IS_WASM, IS_MUSL,
IS_PYPY
)
from numpy.testing._private.utils import _glibc_older_than

Expand Down Expand Up @@ -1888,6 +1889,7 @@ class TestFRExp:
@pytest.mark.parametrize("dtype", ['f', 'd'])
@pytest.mark.skipif(not sys.platform.startswith('linux'),
reason="np.frexp gives different answers for NAN/INF on windows and linux")
@pytest.mark.xfail(IS_MUSL, reason="gh23049")
def test_frexp(self, dtype, stride):
arr = np.array([np.nan, np.nan, np.inf, -np.inf, 0.0, -0.0, 1.0, -1.0], dtype=dtype)
mant_true = np.array([np.nan, np.nan, np.inf, -np.inf, 0.0, -0.0, 0.5, -0.5], dtype=dtype)
Expand Down
0