8000 API: Add Array API aliases (math, bitwise, linalg, misc) [Array API] by mtsokol · Pull Request #25086 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

API: Add Array API aliases (math, bitwise, linalg, misc) [Array API] #25086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ngoldbaum merged 3 commits into from
Dec 8, 2023
Merged

API: Add Array API aliases (math, bitwise, linalg, misc) [Array API] #25086

ngoldbaum merged 3 commits into from
Dec 8, 2023
+213 −125

Conversation

@mtsokol
Copy link
Member
@mtsokol mtsokol commented Nov 7, 2023 •
edited
Loading

Hi @rgommers @ngoldbaum,

This PR adds Array API compatible functions that are direct aliases of existing functions:

  • trigonometry: acos, acosh, asin, asinh, atan, atanh, atan2
  • bitwise: bitwise_left_shift, bitwise_invert, bitwise_right_shift
  • linalg: tensordot, matmul
  • misc: concat, permute_dims, pow

Tracking issue: #25076

@mtsokol mtsokol self-assigned this Nov 7, 2023
@mtsokol mtsokol mentioned this pull request Nov 7, 2023
Closed
23 tasks
@mtsokol mtsokol changed the title API: Add Array API aliases (math, bitwise, misc) API: Add Array API aliases (math, bitwise, misc) [Array API] Nov 7, 2023
eendebakpt
eendebakpt reviewed Nov 7, 2023
View reviewed changes
eendebakpt
eendebakpt reviewed Nov 7, 2023
View reviewed changes
ngoldbaum
ngoldbaum reviewed Nov 8, 2023
View reviewed changes
Copy link
Member
@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a language tweak for the release note

@ngoldbaum
Copy link
Member
ngoldbaum commented Nov 9, 2023

Looks good to me. Since this has only been open for two days and it's adding new things to the public API I'm going to wait until next week to merge this. In the meantime if anyone has any issues with adding these new aliases please let us know.

@mtsokol mtsokol changed the title API: Add Array API aliases (math, bitwise, misc) [Array API] API: Add Array API aliases (math, bitwise, linalg, misc) [Array API] Nov 15, 2023
@mtsokol mtsokol force-pushed the array-api-aliases branch 2 times, most recently from 84a5b5a to c6c5c7a Compare November 29, 2023 11:03
@mtsokol mtsokol added this to the 2.0.0 release milestone Nov 29, 2023
@ngoldbaum
Copy link
Member
ngoldbaum commented Dec 5, 2023

This one has conflicts too! Sorry about not merging this in timely manner like I said I would a month ago.

@mtsokol mtsokol force-pushed the array-api-aliases branch 2 times, most recently from 3236f0f to 7b077e2 Compare December 6, 2023 10:15
@mtsokol
Copy link
Member Author
mtsokol commented Dec 6, 2023 •
edited
Loading

I rebased it, now CI is green!

mtsokol and others added 3 commits December 8, 2023 15:07
@mtsokol @ngoldbaum
API: Add a batch of Array API aliases
7f9549b 
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>

Co-authored-by: Nathan Goldbaum <nathan.goldbaum@gmail.com>
@mtsokol
API: Add tensordot to linalg
2c5603c
@mtsokol
API: Add matmul to linalg
0c3cad6
@ngoldbaum
Copy link
Member
ngoldbaum commented Dec 8, 2023

OK, let's pull this one in next. Thanks @mtsokol!

@ngoldbaum ngoldbaum merged commit a5b67bb into numpy:main Dec 8, 2023
@neutrinoceros neutrinoceros mentioned this pull request Dec 8, 2023
Closed
@mtsokol mtsokol deleted the array-api-aliases branch December 8, 2023 23:58
@dhomeier dhomeier mentioned this pull request Dec 11, 2023
Merged
1 task
@rgommers rgommers mentioned this pull request Jan 15, 2024
Merged
@ksunden ksunden mentioned this pull request Jan 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngoldbaum ngoldbaum ngoldbaum left review comments

+1 more reviewer

@eendebakpt eendebakpt eendebakpt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mtsokol mtsokol

Labels

30 - API Numpy 2.0 API Changes

Projects

None yet

Milestone

2.0.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@mtsokol @ngoldbaum @eendebakpt
0