8000 MAINT: default to C11 rather than C99, fix most build warnings with Clang 14 by rgommers · Pull Request #25072 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT: default to C11 rather than C99, fix most build warnings with Clang 14 #25072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 13, 2023
Merged

MAINT: default to C11 rather than C99, fix most build warnings with Clang 14 #25072

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2481321
MAINT: improve debugging code in `umath_linalg.cpp` so it doesn't emi…
rgommers Nov 4, 2023
b043ff6
MAINT: fix comparison in npysort/selection.cpp so it doesn't emit a w…
rgommers Nov 4, 2023
ceccff0
MAINT: fix unused function warning in `multiarray/item_selection.c`
rgommers Nov 4, 2023
a9ae89c
BLD: use C11 rather than C99 as the C standard version we target
rgommers Nov 4, 2023
5d8a1db
MAINT: remove GCC pragmas that cause warnings with Clang
rgommers Nov 4, 2023
95f8b6c
MAINT: delete duplicate `simd_cabsolute_f32/f64` functions
rgommers Nov 5, 2023
0ee0b6f
BLD: update minimum Cython version to 3.0.6
rgommers Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
MAINT: fix comparison in npysort/selection.cpp so it doesn't emit a w… 
…arning

That warning was, with clang on macOS:
```
../numpy/_core/src/npysort/selection.cpp:529:15: warning: result of comparison of constant 1 with expression of type 'NPY_SELECTKIND' is always false [-Wtautological-constant-out-of-range-compare]
    if (which >= NPY_NSELECTS) {
```
  • Loading branch information
@rgommers
rgommers committed Dec 13, 2023
commit b043ff6d32a298dc27fb0cdfced39b096f0912b8
2 changes: 1 addition & 1 deletion numpy/_core/src/npysort/selection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ _get_partition_func(int type, NPY_SELECTKIND which)
npy_intp i;
npy_intp ntypes = partition_t::map.size();

if (which >= NPY_NSELECTS) {
if ((int)which < 0 || (int)which >= NPY_NSELECTS) {
return NULL;
}
for (i = 0; i < ntypes; i++) {
Expand Down
0