ENH: Add Cython enumeration for NPY_FR_GENERIC #24923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably worth adding to https://github.com/numpy/numpy/blob/main/numpy/__init__.cython-30.pxd too (which will be used instead by Cython 3) |
|
Safe to add and no need to hide it from Cython, thanks @WillAyd. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Oct 18, 2023
Add Cython enumeration for NPY_FR_GENERIC
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Nov 11, 2023
Add Cython enumeration for NPY_FR_GENERIC
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this downstream in pandas. I think it is an oversight to have been left out of the Cython file
numpy/numpy/core/include/numpy/ndarraytypes.h
Line 258 in 67539a4