CI: Switch SIMD tests to meson #24625
Conversation
|
LGTM, but I'll wait for another review. |
There was a problem hiding this comment.
This looks great to me, thanks @seiko2plus! I only have one comment about GCC 9 installation not being successful.
| run: | | ||
| echo "::group::Meson Log" | ||
| cat build/meson-logs/meson-log.txt | ||
| echo "::endgroup::" |
There was a problem hiding this comment.
This step being included with all the others results in log browsing being a bit slow, since it's >10,000 lines as a result of meson-log.txt being so large. It's hidden by default though, and I think this is fine as a price to pay for such a concise linux_simd.yml file. So I wanted to note this, but no change needed.
|
|
||
| armv7_simd_test: |
There was a problem hiding this comment.
For completeness: a superset of this test is now tested in linux_qemu.yml, so this removal is expected.
| export NUMPY_SITE=$(realpath build-install/usr/lib/python*/site-packages/) | ||
| export PYTHONPATH="$PYTHONPATH:$NUMPY_SITE" | ||
| cd build-install && | ||
| sde -spr -- python -c "import numpy; numpy.show_config()" && |
There was a problem hiding this comment.
This was meant to show CPU info of the machine the CI job landed on (was useful to figure out the bug in SDE).
| sde -spr -- python -c "import numpy; numpy.show_config()" && | |
| python -c "import numpy; numpy.show_config()" && |
There was a problem hiding this comment.
The sde -spr usage doesn't seem needed to me here indeed. But it'll work either way, the output in the CI log seems fine. Does that sound right? If so, I can take this along in a follow-up (need to make more CI tweaks soon).
The SIMD tests have been transitioned to utilize the Meson build system. The Intel SDE tests are now consolidated into a single action. Additionally, the Arm7 test has been removed as it is already covered by Linux QEMU tests for armhf.
0866567 to
9dbb984
Compare
Backport of numpy#24625.
Backport of numpy#24625.
Backport of numpy#24625.
Backport of numpy#24625.
All SIMD tests have been transitioned to utilize the Meson build system.
The Intel SDE tests are now consolidated into a single action.
Additionally, the Arm7 test has been removed as it is already
covered by Linux QEMU tests for armhf.