CI: Exclude import libraries from list of DLLs on Cygwin. #24570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are import libraries in numpy.random that are intended for distribution. This script should not include those, only actual DLLs.
|
Looks good, but I am not clear on what the difference does. Could you add a bit of explanation? |
|
Thanks @DWesl . |
|
Import libraries, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are import libraries in numpy.random (with extension
.dll.a) that are intended for distribution. The script to list DLLs on Cygwin should not include those, only actual DLLs.See #24206 for the issue prompting this PR.