-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
CI: remove obsolete jobs, and move macOS and conda Azure jobs to Meson and GHA #24520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hmm, the macOS OpenBLAS installs on Azure were already broken, and despite the title were disabled with |
9c51a9d
to
5bab6cd
Compare
Debugging Azure, so much fun. I think this has to do with picking up the local repo's
EDIT: indeed, due to running |
d3503ec
to
a0ebf4b
Compare
I can't believe that those macOS jobs are still failing. I'm inclined to throw them out and implement new macOS x86-64 jobs on GitHub Actions, that's going to be faster and more future-proof. Any objections? |
There are timing out a lot, and ppc64le was recently disabled. We now have QEMU-based jobs in GitHub Action for these platforms. [skip azp] [skip cirrus] [skip circle] [skip actions]
We still have several other jobs that use ILP64, and this setup.py based job does nothing special. Hence, let's remove it. [skip cirrus] [skip circle] [skip azp]
The use of conda and testing on macOS is nice to combine; no need for the separate jobs. Same for the almost 100% duplication of the two macOS Azure jobs - we can use only one here. Code coverage is removed, because it's done in another job on Linux already, and uploading to Azure isn't all that useful. Some more cleanups to comments and code structure, so that the job is reasonably readable now.
[skip cirrus] [skip circle]
[skip cirrus] [skip circle]
Okay, this is happy now. The one failure in the Emscripten job is unrelated. The removed refguide check from the Azure macOS jobs should go into the CircleCI refguide check, but I'm leaving that to a follow-up to not touch three different CI systems at once. |
Thanks Ralf. |
See commit messages of individual commits for more context. Should be straightforward (assuming CI passes). Some of the code coverage measurements is an easy delete, because that's a ton of boilerplate that does pretty much nothing. We should have code coverage in one job only, and keep all other jobs readable.
Addresses a few tasks from gh-24410.