8000 CI: remove obsolete jobs, and move macOS and conda Azure jobs to Meson and GHA by rgommers · Pull Request #24520 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

CI: remove obsolete jobs, and move macOS and conda Azure jobs to Meson and GHA #24520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 25, 2023

Conversation

rgommers
Copy link
Member

See commit messages of individual commits for more context. Should be straightforward (assuming CI passes). Some of the code coverage measurements is an easy delete, because that's a ton of boilerplate that does pretty much nothing. We should have code coverage in one job only, and keep all other jobs readable.

Addresses a few tasks from gh-24410.

@rgommers
Copy link
Member Author

Hmm, the macOS OpenBLAS installs on Azure were already broken, and despite the title were disabled with BLAS=None etc. env vars. That's a little useless. It seems like openblas.pc/openblas64.pc isn't copied to /usr/local/lib/. I think I'll keep it at -Dallow-noblas for now, and we can fix the problem later once we have OpenBLAS wheels.

@rgommers rgommers force-pushed the ci-to-meson branch 2 times, most recently from 9c51a9d to 5bab6cd Compare August 24, 2023 15:08
@rgommers
Copy link
Member Author
rgommers commented Aug 24, 2023

Debugging Azure, so much fun. I think this has to do with picking up the local repo's numpy rather than the installed version - but it could be related to version git has stuff too:

ImportError while loading conftest '/Users/runner/work/1/s/numpy/conftest.py'.
numpy/__init__.py:101: in <module>
    from . import version
E   ImportError: cannot import name 'version' from partially initialized module 'numpy' (most likely due to a circular import) (/Users/runner/work/1/s/numpy/__init__.py)

EDIT: indeed, due to running pytest without cd tools. A directory change does not carry over between script steps.

@rgommers rgommers added this to the 2.0.0 release milestone Aug 24, 2023
@rgommers rgommers force-pushed the ci-to-meson branch 2 times, most recently from d3503ec to a0ebf4b Compare August 24, 2023 16:14
@rgommers
Copy link
Member Author

I can't believe that those macOS jobs are still failing. I'm inclined to throw them out and implement new macOS x86-64 jobs on GitHub Actions, that's going to be faster and more future-proof. Any objections?

There are timing out a lot, and ppc64le was recently disabled.
We now have QEMU-based jobs in GitHub Action for these platforms.

[skip azp] [skip cirrus] [skip circle] [skip actions]
We still have several other jobs that use ILP64, and this setup.py
based job does nothing special. Hence, let's remove it.

[skip cirrus] [skip circle] [skip azp]
The use of conda and testing on macOS is nice to combine;
no need for the separate jobs. Same for the almost 100%
duplication of the two macOS Azure jobs - we can use only
one here.

Code coverage is removed, because it's done in another job on
Linux already, and uploading to Azure isn't all that useful.
Some more cleanups to comments and code structure, so that the
job is reasonably readable now.
[skip cirrus] [skip circle]
@rgommers rgommers changed the title CI: remove obsolete jobs, and move macOS and conda jobs on Azure to Meson CI: remove obsolete jobs, and move macOS and conda Azure jobs to Meson and GHA Aug 25, 2023
@rgommers
Copy link
Member Author

Here are representative timings for the 3 removed Azure jobs:

image

The new macOS conda job on GHA takes ~23 minutes on an empty cache, and ~14 minutes when the cache is populated. So we're gaining ~3x here in total CI runtime.

@rgommers rgommers marked this pull request as ready for review August 25, 2023 10:59
@rgommers
Copy link
Member Author

Okay, this is happy now. The one failure in the Emscripten job is unrelated. The removed refguide check from the Azure macOS jobs should go into the CircleCI refguide check, but I'm leaving that to a follow-up to not touch three different CI systems at once.

@charris charris merged commit 105cc8d i 8000 nto numpy:main Aug 25, 2023
@charris
Copy link
Member
charris commented Aug 25, 2023

Thanks Ralf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0