8000 MAINT: remove `setup.py` and other files for distutils builds by rgommers · Pull Request #24519 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT: remove setup.py and other files for distutils builds #24519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2023
Merged

MAINT: remove setup.py and other files for distutils builds #24519

merged 3 commits into from
Sep 15, 2023

Conversation

rgommers
Copy link
Member

Not yet merge-able, but running all CI jobs to see what's left.

@rgommers rgommers marked this pull request as draft August 24, 2023 11:27
@rgommers rgommers mentioned this pull request Aug 24, 2023
Closed
@rgommers
CI: disable Emscripten job
80b65e0 
Moving it to Meson is going to take a bit of time, and in the meantime
we have to disable it, because it's the only job that still needs
the `setup.py` based build and we'd like to remove support for building
with `setup.py`.
@rgommers
MAINT: remove all setup.py's and related files for distutils builds
63a1fee
@rgommers
MAINT: update .gitignore and .gitattributes for removed files
59b4955
@rgommers rgommers added this to the 2.0.0 release milestone Sep 13, 2023
@rgommers
Copy link
Member Author

One more CI job to deal with, the relaxed_strides_debug one. I raised the question about what to do with it at #21039 (comment).

@rgommers rgommers marked this pull request as ready for review September 15, 2023 20:22
@rgommers
8000
Copy link
Member Author
rgommers commented Sep 15, 2023 •
edited
Loading

This is now ready to merge. Of the two failures here, the debug job was an apt update issue that's fixed in main, and the relaxed-strides-debug job has been removed in main.

We discussed this change in the community meeting last Wednesday, and everyone there was in favor of removing the setup.py builds as soon as that was feasible, since (a) without CI coverage it's going to degrade quickly anyway, (b) continuing to support two build systems is extra work when making any changes that require touching the build system, and (c) we continue getting bug reports from users that invoke the setup.py build.

@charris charris merged commit 399c0c5 into numpy:main Sep 15, 2023
@charris
Copy link
Member
charris commented Sep 15, 2023

Thanks Ralf.

@rgommers rgommers deleted the remove-setuppy branch September 17, 2023 18:22
@agriyakhetarpal agriyakhetarpal mentioned this pull request Feb 29, 2024
Closed
7 tasks
@lesteve lesteve mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charris charris charris approved these changes

Assignees
No one assigned
Labels
03 - Maintenance
Projects
None yet
Milestone
2.0.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@rgommers @charris @hoodmane
0