8000 BUG: Use a default assignment for git_hash [skip ci] by mattip · Pull Request #24511 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUG: Use a default assignment for git_hash [skip ci] #24511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

mattip
Copy link
Member
@mattip mattip commented Aug 23, 2023

Fixes #24503

Is there a way to easily test this?

@charris charris changed the title use a default assignment for git_hash [skip ci] BUG: Use a default assignment for git_hash [skip ci] Aug 23, 2023
@charris charris added 00 - Bug 09 - Backport-Candidate PRs tagged should be backported labels Aug 23, 2023
@charris charris added this to the 1.26.0 release milestone Aug 23, 2023
mkoeppe added a commit to mkoeppe/sage that referenced this pull request Aug 23, 2023
@charris charris merged commit 07a2e85 into numpy:main Aug 23, 2023
@charris
Copy link
Member
charris commented Aug 23, 2023

Thanks Matti.

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Aug 24, 2023
@charris charris removed this from the 1.26.0 release milestone Aug 24, 2023
@mattip mattip deleted the issue-24503 branch May 5, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: numpy 1.26.0b1 fails to build from sdist when no git is present
2 participants
0