DOC: Add missing changelogs for NEP 52 PRs #24510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
reviewed
Aug 23, 2023
charris
reviewed
Aug 23, 2023
charris
reviewed
Aug 23, 2023
| @@ -1,45 +1,313 @@ | |||
| .. currentmodule:: numpy | |||
charris
reviewed
Aug 23, 2023
|
|
||
| Highlights | ||
| ========== | ||
| ========================= | ||
|
|
||
|
|
||
| New functions | ||
| ============= |
There was a problem hiding this comment.
What should be the desired indentation here?
I see that e.g. 1.23.0-notes.rst also has New functions written this way.
There was a problem hiding this comment.
Happens, the notes get copied one to another :) Probably doesn't matter, but headings flush on left works.
|
Couple of nits. If you hit the |
|
Thanks @mtsokol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rgommers,
This PR contains two commits: One with release notes that I obtained by running:
And second one with manually added release notes for four merged Python API cleanup PRs: #23830, #24154, #24316, #24357.