8000 Avoid spurious double cast in _monotonicity by LemonBoy · Pull Request #24449 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

Avoid spurious double cast in _monotonicity #24449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Avoid spurious double cast in _monotonicity #24449

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aeb6620
Avoid spurious double cast in _monotonicity
LemonBoy Aug 18, 2023
a691e6a
fixup! Amend some silly errors
LemonBoy Aug 18, 2023
3d09073
fixup! Fix typo that snuck in during rebase 8000
LemonBoy Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! Amend some silly errors 
Spotted during code review.
  • Loading branch information
@LemonBoy
LemonBoy authored and Giuseppe Musacchio committed Sep 7, 2023
commit a691e6a13529f005f25b676a7aad8d7157e2b5eb
4 changes: 2 additions & 2 deletions numpy/core/src/multiarray/compiled_base.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,9 @@ arr__monotonicity(PyObject *NPY_UNUSED(self), PyObject *args, PyObject *kwds)

if (PyArray_DESCR(array)->f->compare == NULL) {
PyErr_SetString(PyExc_TypeError,
"type does not have compare function");
"dtype %S does not have compare function", array);
Py_DECREF(array);
return -1;
return NULL;
}

assert(PyArray_TRIVIALLY_ITERABLE(array));
Expand Down
0