8000 BUG: Fix assumed length f2py regression by HaoZeke · Pull Request #24299 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: Fix assumed length f2py regression #24299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 25, 2023
Merged

BUG: Fix assumed length f2py regression #24299

merged 5 commits into from
Aug 25, 2023

Conversation

HaoZeke
Copy link
Member
@HaoZeke HaoZeke commented Jul 31, 2023

Closes #24008. Many thanks to @Akahan12 for narrowing down the problematic commit.

@charris this will need a backport.

@HaoZeke HaoZeke requested a review from melissawm July 31, 2023 06:35
@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Jul 31, 2023
@HaoZeke HaoZeke force-pushed the gh24008_regression_f2py branch from ae81cf9 to 3b862dd Compare August 5, 2023 19:53
@HaoZeke
Copy link
Member Author
HaoZeke commented Aug 5, 2023

Travis build failure seems unrelated.

@HaoZeke HaoZeke mentioned this pull request Aug 23, 2023
Merged
@mattip
Copy link
Member
mattip commented Aug 24, 2023

Which test run covers f2py + slow tests?

HaoZeke added 5 commits August 24, 2023 10:51
@HaoZeke
BUG: Fix f2py F77 assumed length issues
1940763 
Closes numpygh-24008. Essentially, array and length setup needs to be done
before the length defaults kick in.
@HaoZeke
TST: Add a test for assumed length F77
819a44b
@HaoZeke
MAINT: move gh24008 to test_character
01664c5 
Since it belongs logically to the tests where character array shapes and
types are determined
@HaoZeke
BUG: Rework character array assignments (numpygh-24008)
a64d3cd
@HaoZeke
TST: Stop marking small f2py tests as slow
9a44f54
@HaoZeke
Copy link
Member Author
HaoZeke commented Aug 24, 2023 •
edited
Loading

The ones with numpy.test(label='full') should cover the slow tests. That said these are no slower than anything else on the CI, so, I updated the tests. The remaining build failure is unrelated, something to do with pd in the doctests, hopefully a rebase will fix it.

@HaoZeke HaoZeke force-pushed the gh24008_regression_f2py branch from e46cf48 to 9a44f54 Compare August 24, 2023 10:52
@HaoZeke
Copy link
Member Author
HaoZeke commented Aug 24, 2023

Should be good to go now, @mattip

@mattip mattip merged commit b6b6f22 into numpy:main Aug 25, 2023
@mattip
Copy link
Member
mattip commented Aug 25, 2023

Thanks @HaoZeke

@charris charris mentioned this pull request Aug 25, 2023
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Aug 25, 2023
@HaoZeke HaoZeke deleted the gh24008_regression_f2py branch September 14, 2023 16:54
@HaoZeke HaoZeke restored the gh24008_regression_f2py branch June 15, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissawm melissawm Awaiting requested review from melissawm

Assignees
No one assigned
Labels
00 - Bug component: numpy.f2py
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: f2py cannot compile files it used to be able to compile
3 participants
@HaoZeke @mattip @charris
0