-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
ENH: create and use indexed inner loops #23136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
90243f5
ENH: add indexed loops
mattip 3ba259d
refactor ufunc_at to first get the inner loop, then create the iterators
mattip 7910e2b
ENH: add indexed lower loops and connect them to ufuncs
mattip eb21b25
ENH: use an indexed loop if possible in ufunc_at
mattip 888bba2
MAINT: fix linting
mattip be64173
ENH: update and sync the public API
mattip 8bfaaf3
BENCH: fix benchmark
mattip 28706af
MAINT, BUG: fixes from review and testing
mattip 1db1ffe
MAINT: linting
mattip ec1a434
MAINT: update EXPERIMENTAL_DTYPE_API_VERSION too
mattip 6541cf5
DOC: add a performance release note
mattip 3802b16
MAINT: rework release note, changes from review
mattip f064552
BUG: Clean up reference handling in `ufunc.at` a little.
seberg 6cf9cc9
BUG: Deal with casting and non-contig/1-D indices
seberg ff97723
BUG: fixes from review: use iter->nd and adapt to unary ufuncs
mattip 163d3c5
BUG: improve check for 1d operands (from review)
mattip f79325e
TST: add test (from review)
mattip b80bc2d
ENH: fixes from review
mattip 26978d7
DOC: improve release snippet (from review)
mattip 790426e
TST, BUG: add a test for unary ufuncs, fix condition for indexed loops
mattip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
``ufunc.at`` can be much faster | ||
------------------------------- | ||
Generic ``ufunc.at`` can be up to 9x faster. The conditions for this speedup: | ||
|
||
- operands are aligned | ||
- no casting | ||
|
||
If ufuncs with appropriate indexed loops on 1d arguments with the above | ||
conditions, ``ufunc.at`` can be up to 60x faster (an additional 7x speedup). | ||
Appropriate indexed loops have been added to ``add``, ``subtract``, | ||
``multiply``, ``divide`` (and ``floor_divide``) | ||
|
||
The internal logic is similar to the logic used for regular ufuncs, which also | ||
have fast paths. | ||
|
||
Thanks to the `D. E. Shaw group <https://deshaw.com/>`_ for sponsoring this | ||
work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.