Fix dtype int vs char inconsistencies + dtype hashing #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since type_num is not considered in PyArray_EquivTypes (for dtype equality comparison), seems reasonable to ignore it for hashing as well.
| /* We use an integer converted to char for backward compatibility with | ||
| * pickled arrays. Pickled arrays created with previous versions encoded | ||
| * flags as an int even though it actually was a char in the PyArray_Descr | ||
| * structure */ |
|
This seems like the right thing to do. What are the implications for pickled arrays of the change? |
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
feat: Add vst3[q]_[s8|s16|s32|f32|u8|u16|u32|s64|u64]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
2E57
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix int->char invalid casts + fix #2017 by ignoring type_num when hashing dtype. Doing the latter is justified by PyArray_EquivTypes which ignores it as well.