-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
MAINT: Replace Python3.8 by Python3.9. #22902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I didn't touch Cygwin in this first trial. Let's what problems the other test have. |
31cca45
to
2dd0f52
Compare
2dd0f52
to
0e99871
Compare
We will drop Python3.8 in NumPy 1.25. This PR updates the ci tests and wheel builds to use 3.9.
@seiko2plus Is the |
0e99871
to
de3e50a
Compare
Just one build is needed to test the sanity of the infrastructure in case of any sudden changes lead to breaking the compile-time detection of CPU features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not merging for a bit in case anyone else had thoughts here.
@@ -12,7 +12,7 @@ jobs: | |||
# therefore a new base image chose instead to guarantee to | |||
# have a newer version >= 1.8.10 to avoid warnings | |||
# that related to the default behaviors or non-exist config options | |||
- image: cimg/base:2021.05 | |||
- image: cimg/python:3.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that python 3.10 and 3.11 are also available. I chose 3.9 as most likely to be compatible with our other documentation dependencies.
OK, lets just get it in, we can always follow up, thanks Chuck. |
@mattip Are you still working to get PyPy 3.9 up for NumPy? |
I am waiting for cibuildwheel to release a version that supports pypy + macos + arm64, which is progessing in pypa/cibuildwheel#1372 |
We will drop Python3.8 in NumPy 1.25. This PR updates the ci tests and wheel builds to use 3.9.
A few observations in getting this working:
The failing PyPy 3.9 tests aren't terrible, we could skip them, but I would rather not at this point.
After this goes in, I'll make another PR using cibuildwheel@v2.11.4 to generate errors so I can report them upstream. We will need this fixed so that later versions with Python 3.12 will work when we begin to support it.