-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
ENH: Speedup ufunc.at when casting is not needed #22889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
7b31199
ENH: find the place to add a fast path for ufunc_at
mattip c266953
refactor ufunc_at in preparation for breaking it into sub-functions
mattip 07c3487
refactor part that does the iteration into function
mattip 7853cbc
add fast iter loop and benchmark
mattip 154c293
MAINT: elide the generic_wrapped_legacy_loop wrapper out of the hot loop
mattip cfa2b17
MAINT: do not try SIMD arithmetic loops if count < 4
mattip ef9f35a
fix for non-generic_legacy lopps
mattip 8b3056c
lower limit to 2, improves benchmarks
mattip 845a327
use better semantics for calling PyArray_DiscardWritebackIfCopy
mattip c95932e
use 4 for float, 2 for double in fast-path count
mattip 333d012
Revert "MAINT: elide the generic_wrapped_legacy_loop wrapper out of t…
mattip 1d4bef6
MAINT: enable fast_path in more cases (from review)
mattip af52e19
MAINT: remove dead code path (from review)
mattip 217e2a7
MAINT: improve coverage of slow path by using a user-defined dtype
mattip 11fa976
MAINT: add missing test cases (from review)
mattip be77b8f
TST: use clean copies
mattip 17388bb
MAINT: remove overly-cautious check (from review)
mattip 471d568
BENCH: use intp dtype when indexing
mattip bd4998c
MAINT: test broadcasting; test, fix output casting (from review)
mattip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy to add this, if @seiko2plus doesn't like it, we can follow up also.