8000 API: No timedelta/datetimes are not integers and do not promote by seberg · Pull Request #22568 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

API: No timedelta/datetimes are not integers and do not promote #22568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

API: No timedelta/datetimes are not integers and do not promote #22568

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
96542b5
API: Disallow promoting timedelta64 with other types
seberg Nov 9, 2022
6b73f2d
API: No, timedelta64 is NOT an integer.. 8000 .
seberg Nov 10, 2022
7c552fb
MAINT: Doing float comparisons in DivisionSafeDomain only makes sense…
seberg Nov 10, 2022
6d89b69
TST: Fix up tests which relied directly on int -> timdelta "promotion"
seberg Nov 10, 2022
21d2775
MAINT: Remove now unnecessary type-resolution path
seberg Dec 13, 2022
fdbda58
DOC: Add release note for timedelta/datetime promotion deprecation
seberg Dec 13, 2022
baa3b37
TYP,WIP: Try to fix up the typing for datetime/timedelta promotion de…
seberg Dec 13, 2022
981d3a7
TST: fixup test for time promotion change
seberg May 15, 2023
a4d4f0c
BUG: Add _ArrayLikeTD64_comp_co rexport, thanks to Bas
seberg May 15, 2023
cd87a78
TYP: Fixup typing and typing tests
seberg May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
MAINT: Remove now unnecessary type-resolution path
  • Loading branch information
@seberg
seberg committed May 15, 2023
commit 21d27756dbcbb4f7d86095cf54179631c5f3d5cd
2 changes: 1 addition & 1 deletion numpy/core/src/umath/ufunc_type_resolution.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ PyUFunc_SimpleBinaryComparisonTypeResolver(PyUFuncObject *ufunc,
* ResultType would give for number->string promotions.
* (We never supported flexible dtypes here.)
*/
else if (!PyArray_ISFLEXIBLE(operands[0]) &&
if (!PyArray_ISFLEXIBLE(operands[0]) &&
!PyArray_ISFLEXIBLE(operands[1])) {
out_dtypes[0] = PyArray_ResultType(2, operands, 0, NULL);
if (out_dtypes[0] == NULL) {
Expand Down
0