10000 DEP: drop older cygwin compatibility shims by mattip · Pull Request #22159 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

DEP: drop older cygwin compatibility shims #22159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2022
Merged

DEP: drop older cygwin compatibility shims #22159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f8129e
DEP: drop older cygwin compatibility shims
mattip Aug 21, 2022
ec95603
fix from review
mattip Aug 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Fa 10000 iled to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/release/upcoming_changes/22159.expired.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Support for cygwin < 3.3 has been removed.
14 changes: 2 additions & 12 deletions numpy/core/src/common/npy_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,18 +138,8 @@

#include <cygwin/version.h>
#if CYGWIN_VERSION_DLL_MAJOR < 3003
/* https://cygwin.com/pipermail/cygwin-announce/2021-October/010268.html */
/* Builtin abs reports overflow */
#undef HAVE_CABSL
#undef HAVE_HYPOTL
#endif

#if CYGWIN_VERSION_DLL_MAJOR < 3002
/* https://cygwin.com/pipermail/cygwin-announce/2021-March/009987.html */
/* Segfault */
#undef HAVE_MODFL
/* sqrt(-inf) returns -inf instead of -nan */
#undef HAVE_SQRTL
// rather than blocklist cabsl, hypotl, modfl, sqrtl, error out
#error cygwin < 3.3 not supported, please update
#endif
#endif

Expand Down
0