8000 MAINT: Simplify npymath by mattip · Pull Request #22090 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT: Simplify npymath #22090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 23, 2022
Merged

MAINT: Simplify npymath #22090

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f33e579
remove obsolete support for Solaris
mattip Aug 7, 2022
e9e8cee
rearrange headers to make npy_config.h only about config
mattip Aug 7, 2022
9e481ad
make optional C99 double routines mandatory
mattip Aug 7, 2022
aceba28
remove ifndef alterantives for mandatory functions
mattip Aug 10, 2022
c35cb18
restore HAVE_LOG2 for cygwin blocklistingw
mattip Aug 11, 2022
16a6405
restore HAVE_POWL for macOS blocklisting
mattip Aug 11, 2022
c304f6f
move hypot to optional for windows, fix pow and log2
mattip Aug 14, 2022
37b2cf1
frexp is now mandatory
mattip Aug 14, 2022
b0878cf
copysign is mandatory, no HAVE_COPYSIGN is defined
mattip Aug 14, 2022
ee2103b
rearrange badly placed header includes
mattip Aug 14, 2022
759e0cd
strtoull and strtoll are mandatory
mattip Aug 15, 2022
2c4cc10
restore atan2 implementation, clean up c99 mandatory functions
mattip Aug 15, 2022
704ca94
nextafter is mandatory
mattip Aug 15, 2022
b6d52fc
remove duplicate C99 functions, ensure optional variant HAVE_ macros …
mattip Aug 16, 2022
d1cbf3f
BUILD: convert HAVE_ macros to BLOCK_, cleanup
mattip Aug 16, 2022
25629dd
TASK: rename macros (from review)
mattip Aug 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
strtoull and strtoll are mandatory
  • Loading branch information
@mattip
mattip committed Aug 21, 2022
commit 759e0cdbc2642211ad2f0adce3ef247428a1e3b3
2 changes: 1 addition & 1 deletion azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ stages:
python3 -m pip install -v . && \
python3 runtests.py -n --deb 8000 ug-info --mode=full -- -rsx --junitxml=junit/test-results.xml && \
python3 tools/openblas_support.py --check_version"
displayName: 'Run 32-bit manylinux2010 Docker Build / Tests'
displayName: 'Run 32-bit manylinux2014 Docker Build / Tests'
- task: PublishTestResults@2
condition: succeededOrFailed()
inputs:
Expand Down
15 changes: 0 additions & 15 deletions numpy/core/src/common/numpyos.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,27 +770,12 @@ NumPyOS_ascii_ftoLf(FILE *fp, long double *value)
NPY_NO_EXPORT npy_longlong
NumPyOS_strtoll(const char *str, char **endptr, int base)
{
#if defined HAVE_STRTOLL
return strtoll(str, endptr, base);
#elif defined _MSC_VER
return _strtoi64(str, endptr, base);
#else
/* ok on 64 bit posix */
return PyOS_strtol(str, endptr, base);
#endif
}

NPY_NO_EXPORT npy_ulonglong
NumPyOS_strtoull(const char *str, char **endptr, int base)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these now more or less pointless wrapper functions be deprecated somehow...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed there is more cleanup that can be done to turn one-line functions into defines (if they are exported) or to deprecate them (if they are internal). I was primarily targeting cleaning up the dead code from npymath in this PR. Maybe we should have a github project for code cleanup and add this as a task.

{
#if defined HAVE_STRTOULL
return strtoull(str, endptr, base);
#elif defined _MSC_VER
return _strtoui64(str, endptr, base);
#else
/* ok on 64 bit posix */
return PyOS_strtoul(str, endptr, base);
#endif
}


0