8000 BUILD: run CI with an older windows toolchain like in wheel building by mattip · Pull Request #21361 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUILD: run CI with an older windows toolchain like in wheel building #21361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mattip
Copy link
Member
@mattip mattip commented Apr 19, 2022

issue #21346:

  • reproduce the problem with a older toolchain in CI
  • fix the problem

@mattip mattip force-pushed the msvc-_knot_mask16 branch 2 times, most recently from b2b06a8 to a46e679 Compare April 19, 2022 14:34
@mattip mattip force-pushed the msvc-_knot_mask16 branch from a46e679 to 615d6ce Compare April 19, 2022 15:28
@mattip
Copy link
Member Author
mattip commented Apr 19, 2022

Closing. I couldn't get the BatchScript task to actually modify the environment. I think anyway #21360 is a better fix for the issue.

- powershell: |
ls openblas
echo What PATH and other environment variables?
echo PATH $Env:PATH
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For those trying to follow what happened, the PATH printed here in CI is not being modified by the previous BatchScript step, so the older 141 toolset is not used. You can see that the PATH printed at the end of tools/set_vs_toolchain.cmd is not the same as the one printed here.

@mattip
Copy link
Member Author
mattip commented Apr 20, 2022

@charris, @matthew-brett can we move the conversation around a CI run with vs 141 here from #21346?

I tried copying exactly the step used in MacPython/numpy-wheels, it didn't work. I printed out the PATH at the end of the step, and the PATH at the beginning of the next one, they are different. The modifyEnvironment directive should have made them the same.

does the step lack a #vso[task.prependpath] set?

I don't see such a call in the code in the step in azure/windows.yml from MacPython/numpy-wheels

@h-vetinari
Copy link
Contributor

can we move the conversation around a CI run with vs 141 here from #21346?

Sidenote: it's suboptimal to do this in a closed issue/PR, because it gets hidden from much more by github, and is therefore easier to overlook. How about reopening (or moving to a different issue)?

@mattip mattip deleted the msvc-_knot_mask16 branch December 27, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0