8000 DEP: Remove support for non-tuple nd-indices. by hawkinsp · Pull Request #21029 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

DEP: Remove support for non-tuple nd-indices. #21029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2022
Merged

DEP: Remove support for non-tuple nd-indices. #21029

merged 1 commit into from
Feb 14, 2022

Conversation

hawkinsp
Copy link
Contributor

This behavior has been deprecated since NumPy 1.15
(#9686).

@hawkinsp hawkinsp mentioned this pull request Feb 10, 2022
Closed
@hawkinsp hawkinsp force-pushed the nontuple_index branch 2 times, most recently from 38d60ed to 74b4f44 Compare February 10, 2022 16:47
@shoyer shoyer requested review from seberg and eric-wieser February 10, 2022 17:43
seberg
seberg reviewed Feb 10, 2022
View reviewed changes
Copy link
Member
@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, finally getting rid of this sounds great! Glancing at the code, I think we can simplify it quite a bit now (or maybe even before). Would you be up to trying that out/doing that? Could be a followup as well though.

@eric-wieser
Copy link
Member

I'll have a quick look over this tomorrow

@seberg
Copy link
Member
seberg commented Feb 10, 2022

I'll have a quick look over this tomorrow

Thanks, I will let you do the honor then, to me this looks good now.

eric-wieser
eric-wieser reviewed Feb 10, 2022
View reviewed changes
@hawkinsp hawkinsp force-pushed the nontuple_index branch 3 times, most recently from 5c3f9d3 to 5e1be78 Compare February 11, 2022 18:27
@hawkinsp
Copy link
Contributor Author

Does this look good?

eric-wieser
eric-wieser reviewed Feb 14, 2022
View reviewed changes
eric-wieser
eric-wieser reviewed Feb 14, 2022
View reviewed changes
@hawkinsp
DEP: Remove support for non-tuple nd-indices.
e352160 
This behavior has been deprecated since NumPy 1.15
(numpy#9686).
@hawkinsp
Copy link
Contributor Author
hawkinsp 8000 commented Feb 14, 2022

Done.

@hawkinsp
Copy link
Contributor Author

The failing checks look unrelated to this PR.

@seberg
Copy link
Member
seberg commented Feb 14, 2022

Thanks, lets put this in! There might be some potential for more simplification now that this is nice, simple, and clean but this is a huge step :).

@seberg seberg merged commit 91d4973 into numpy:main Feb 14, 2022
@gnodar01 gnodar01 mentioned this pull request Jul 18, 2022
Merged
@tonywong94 tonywong94 mentioned this pull request Aug 18, 2022
Merged
@histed histed mentioned this pull request Aug 19, 2022
Closed
@CodeByDrescher CodeByDrescher mentioned this pull request Sep 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberg seberg seberg left review comments

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
07 - Deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkinsp @eric-wieser @seberg
0