8000 DOC: Update ndarray.argmax + argmin documentation with keepdims param #20700 by rjeb · Pull Request #20834 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

DOC: Update ndarray.argmax + argmin documentation with keepdims param #20700 #20834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2022
Merged

DOC: Update ndarray.argmax + argmin documentation with keepdims param #20700 #20834

merged 2 commits into from
Jan 18, 2022

Conversation

rjeb
Copy link
Contributor
@rjeb rjeb commented Jan 17, 2022

ndarray argmax and argmin had keepdims parameter that wasn't documented in it's docstring shown in #20700.
New documentation:
new_generated_documentation

Mukulikaa
Mukulikaa approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor
@Mukulikaa Mukulikaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rjeb. LGTM.

HaoZeke
HaoZeke requested changes Jan 17, 2022
View reviewed changes
HaoZeke
HaoZeke approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member
@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thanks @Mukulikaa and @rjeb

@mattip mattip merged commit 5559e27 into numpy:main Jan 18, 2022
@mattip
Copy link
Member
mattip commented Jan 18, 2022

Thanks @rjeb

@InessaPawson
Copy link
Member

Hi-five on merging your first pull request to NumPy, @rjeb! We hope you stick around! Your choices aren’t limited to programming – you can review pull requests, help us stay on top of new and old issues, develop educational material, work on our website, add or improve graphic design, create marketing materials, translate website content, write grant proposals, and help with other fundraising initiatives. For more info, check out: https://numpy.org/contribute/.
Also, consider joining our mailing list. This is a great way to connect with other cool people in our community and be part of important conversations that affect the development of NumPy: https://mail.python.org/mailman/listinfo/numpy-discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoZeke HaoZeke HaoZeke approved these changes

@Mukulikaa Mukulikaa Mukulikaa approved these changes

Assignees
No one assigned
Labels
04 - Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rjeb @mattip @InessaPawson @HaoZeke @Mukulikaa
0