8000 BUG: datetime64 hash by shubham11941140 · Pull Request #19724 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: datetime64 hash #19724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

BUG: datetime64 hash #19724

wants to merge 0 commits into from

Conversation

shubham11941140
Copy link
Contributor
@shubham11941140 shubham11941140 commented Aug 21, 2021 •
edited
Loading

Reviving #14622

@mattip
Copy link
Member
mattip commented Aug 22, 2021

Please link to previous work like PR #14622 and to the issue this is meant to solve #3836. I don't understand this resubmission: have you changed something and why? Is there a reason you didn't simply add your unique contribution to the comments there?

It seems this is the third such attempt at resubmitting previous PRs - #19718, #19720, and now this one. None of these PRs have descriptions or hints that that they are resubmissions of previous work. Please refrain from wasting precious reviewer time and CI resources.

@mattip mattip closed this Aug 22, 2021
@shubham11941140
Copy link
Contributor Author

Please reopen the PR so I can delete the previous commit and update it with a new one.

@mattip
Copy link
Member
mattip commented Aug 22, 2021

I prefer to continue with the older PR. If there are things needed to fix there, you can submit a PR to https://github.com/walshb/numpy/tree/bw-datetime-hash-3836.

@shubham11941140
Copy link
Contributor Author

I understand this, but I just wanted to clear up a few files in this PR.

@mattip mattip reopened this Aug 22, 2021
@shubham11941140
Copy link
Contributor Author

Please reopen: #19720 and #19718

@eric-wieser
Copy link
Member

It appears that @shubham11941140 is trying to remove the evidence that they attempted to pass off other code as their own. Two things to note:

  • You can always push commits to an already closed PR
  • git doesn't forget; bdf7457 still exists even though its not in this PR.

@shubham11941140 shubham11941140 deleted the patch4 branch August 22, 2021 13:30
@shubham11941140
Copy link
Contributor Author

I am not able to commit to a closed PR.

@shubham11941140 shubham11941140 restored the patch4 branch August 22, 2021 13:37
@shubham11941140 shubham11941140 deleted the patch4 branch August 22, 2021 13:41
@shubham11941140 shubham11941140 restored the patch4 branch August 22, 2021 13:44
@shubham11941140
Copy link
Contributor Author

Please remove the comments that involve copying as I have mentioned the revival of an old PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
00 - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubham11941140 @mattip @eric-wieser
0