8000 MAINT: Use "with open(...)" by jakobjakobson13 · Pull Request #19442 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT: Use "with open(...)" #19442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2021
Merged

MAINT: Use "with open(...)" #19442

merged 2 commits into from
Jul 9, 2021

Conversation

jakobjakobson13
Copy link
Contributor

No description provided.

@jakobjakobson13 jakobjakobson13 changed the title MAINT: Use "with open(...)" in _version.py MAINT: Use "with open(...)" Jul 9, 2021
@mattip
Copy link
Member
mattip commented Jul 9, 2021

This is very hard to review with all the spurious codecov warnings

@seberg
Copy link
Member
seberg commented Jul 9, 2021

@charris the changes look good, but I susppect we don't want to modify this because it is just versioneer being vendored?

@charris
Copy link
Member
charris commented Jul 9, 2021 •
edited
Loading

it is just versioneer being vendored?

Versioneer created it, but it won't hurt to fix it. To be precise, versioneer created _version.py. I've already modified the code so that it works for the wheels when we have uncommitted license files that would otherwise result in dirty as part of the version.

@charris charris merged commit df9c973 into numpy:main Jul 9, 2021
@charris
Copy link
Member
charris commented Jul 9, 2021

Thanks @jakobjakobson13.

@jakobjakobson13 jakobjakobson13 deleted the Use_with_open branch July 10, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 - Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakobjakobson13 @mattip @seberg @charris
0