Maintenance/1.21.x #19333
Closed
Maintenance/1.21.x #19333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compile-time test of POPCNT, cpu_popcnt.c produced code that would execute without error even if the machine didn't support the popcnt instruction. This patch attempts to use popcnt on random numbers so the compiler can't substitute the answer at compile time.
_builtin_popcount is always available, so the compile-time check always succeeds.
- Make versions of the form '1.22.0.dev0' valid for non-releases. - Put empty match at end of groups instead of at the beginning. - Require eol in match, do not allow trailing characters.
BUG: Fix compile-time test of POPCNT
BUG: Fix test_numpy_version.
No changes for the NumPy 1.21.x release.
REL: Prepare 1.21.0 release
…or underlying types with >1 parameters
BUG: Fixed an issue wherein `_GenericAlias.__getitem__` would raise for types with >1 parameters
That was the original intent, but linter was only disabled for merges to the main branch and still ran, and failed, on maintenance branches. Closes #19079.
BUG: Linter should only run on pull requests.
This fixes setup.py to correctly detect the release status and base version from the full version string provided by versioneer. Before this fix, versions like '1.22.0.dev0+...' were correctly handled, but versions like '1.21.0rc1+...' were not.
BUG: Fix setup.py to work in maintenance branches.
BUG: expose short_version as previously in version.py
Unfortunately, this seems to cause some pain in pandas at least to circumvent the warning. Delaying may complicate the creation of ufuncs for strings, but otherwise should not be a big problem. We have to make sure that we can reimplement the change quickly though, it is an important change in my opinion.
API: Delay string and number promotion deprecation/future warning
…time Unlike GCC and CLANG, Intel Compiler exposes all supported intrinsics, whether or not the build options for those features are specified. Therefore, we must test #definitions of CPU features when option native/host is enabled via `--cpu-baseline` or through env var `CFLAGS` otherwise the test will be broken and leads to enable all possible features.
Numpy will not build if this is not set because it has code that follows the c99 standard. icc is set to c89 by default. Look below at IntelCCompilerW which is the icc equivalent on Windows and that one already has c99 set.
BUG, SIMD: Fix detect host/native CPU features on ICC at compile-time
BUG: Add -std=c99 to intel icc compiler flags on linux
This accepts NEP 35 as final. There has been no discussion about it in a long time. The current mode is strict about type input (`like=` must be an array-like). So that most of the "open" points are OK to remain open. Unless we need to discuss the name `like` or the fact that we pass an array-like itself, the previously noted open points gh-17075 all seem not very relevant anymore.
ENH: Support major version larger than 9 in NumpyVersion
BUG: Fix out-of-bounds access in convert_datetime_divisor_to_multiple
Also update pinned version of sphinx in environment.yml Fixes gh-19028
BUG: Invalid dtypes comparison should not raise TypeError
DOC: fix duplicate navbar in development documentation index
Pretty, harmless reference count leak (the method is a singleton)
This slightly reorganizes the error path handling (duplicating the freeing for the non-error path). It just seemed a bit clearer.
BUG: Add missing DECREF in new path
The removed directory also contained a release fragment that this commit adds to the 1.21.0-release notes.
REL: Prepare for 1.21.0 release
REV,BUG: Replace `NotImplemented` with `typing.Any`
The latter two would previously return complex arrays if the initial array was also complex
MAINT: Fixed the return-dtype of `ndarray.real` and `imag`
…rrayLike` Strings and types that are not subscriptable during runtime can cause issues with runtime Introspection helpers such as `typing.get_type_hints`. While this is very much an upstream issue, the particular case of `npt.ArrayLike` can be quite easily resolved in numpy.
…h runtime Introspection helpers * `typing.get_type_hints` * `typing.get_args` * `typing.get_origin`
MAINT: Replace `"dtype[Any]"` with `dtype` in the definiton of `npt.ArrayLike`
|
This was already done in #19090 . You are also working off the wrong branch, start by making a working branch off main and then make a PR from that branch. |
|
There is also an existing PR removing unused variables, #19102, so you should look for other LGTM warnings. |
|
I'm going to close this. @helizaga Thanks for the attempt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.