8000 BUG: Add missing DECREF in new path by seberg · Pull Request #19277 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUG: Add missing DECREF in new path #19277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2021
Merged

BUG: Add missing DECREF in new path #19277

merged 2 commits into from
Jun 18, 2021

Conversation

seberg
Copy link
Member
@seberg seberg commented Jun 18, 2021

Pretty, harmless reference count leak (the method is a singleton)

Pretty, harmless reference count leak (the method is a singleton)
@seberg seberg added the 09 - Backport-Candidate PRs tagged should be backported label Jun 18, 2021
This slightly reorganizes the error path handling (duplicating
the freeing for the non-error path).  It just seemed a bit clearer.
@seberg
Copy link
Member Author
seberg commented Jun 18, 2021

I may add commits as the leak-checking goes (this is pytest-leaks now, valgrind seemed fine on the 1.21 branch). But don't wait for my run to finish to merge...

@charris charris merged commit 054c6db into numpy:main Jun 18, 2021
@charris
Copy link
Member
charris commented Jun 18, 2021

Thanks Sebastian.

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jun 19, 2021
@seberg seberg deleted the missing-decref branch June 19, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0