8000 NEP: Accept NEP 35 as final by charris · Pull Request #19193 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

NEP: Accept NEP 35 as final #19193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2021
Merged

NEP: Accept NEP 35 as final #19193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
NEP: Accept NEP 35 as final 
This accepts NEP 35 as final.  There has been no discussion about it
in a long time.  The current mode is strict about type input
(`like=` must be an array-like).  So that most of the "open" points
are OK to remain open.
Unless we need to discuss the name `like` or the fact that we pass
an array-like itself, the previously noted open points gh-17075
all seem not very relevant anymore.
  • Loading branch information
@seberg @charris
seberg authored and charris committed Jun 7, 2021
commit bbdc753a9ccb038a13ad4ec8e3cb9361483dc0de
4 changes: 2 additions & 2 deletions doc/neps/nep-0035-array-creation-dispatch-with-array-function.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ NEP 35 — Array Creation Dispatching With __array_function__
===========================================================

:Author: Peter Andreas Entschev <pentschev@nvidia.com>
:Status: Draft
:Status: Final
:Type: Standards Track
:Created: 2019-10-15
:Updated: 2020-11-06
:Resolution:
:Resolution: https://mail.python.org/pipermail/numpy-discussion/2021-May/081761.html

Abstract
--------
Expand Down
6 changes: 1 addition & 5 deletions numpy/core/overrides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,7 @@
NumPy arrays. If an array-like passed in as ``like`` supports
the ``__array_function__`` protocol, the result will be defined
by it. In this case, it ensures the creation of an array object
compatible with that passed in via this argument.

.. note::
The ``like`` keyword is an experimental feature pending on
acceptance of :ref:`NEP 35 <NEP35>`."""
compatible with that passed in via this argument."""
)

def set_array_function_like_doc(public_api):
Expand Down
0